chore: Add notification content row number configuration #956
Conversation
| Q_EMIT dataChanged(index(row), index(row), {BubbleModel::TimeTip}); | ||
| } | ||
| }); | ||
| connect(bubble, &BubbleItem::contentRowCountChanged, this, [this, bubble] { |
There was a problem hiding this comment.
对于replace的bubble,不走push,是不是就没连接这个信号了，上面的timeTipChanged也有类似的问题，
看要不要直接提供个方法出去，让外部接收到dconfig改变的信号时，主动去调用，刷新一次，
| return std::min(OverlayMaxCount, overlapCount()); | ||
| } | ||
| } else if (role == NotifyRole::NotifyContentRowCount) { | ||
| return notify->contentRowCount(); |
There was a problem hiding this comment.
这个是不是可以直接返回NotifySetting::instance()->contentRowCount()，单个的notify的rowCount应该是一样的，
yixinshark
force-pushed
the
chore-contentRowConfig
branch
2 times, most recently
from
f2ae9f0 to
1d3d3c7
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
as title Log: as title pms: BUG-289409
as title Log: as title
yixinshark
force-pushed
the
chore-contentRowConfig
branch
from
fd49d2a to
c9956c4
Compare
|
/forcemerge |
|
This pr force merged! (status: blocked) |
deepin pr auto review代码审查意见：
|
3 participants
as title
Log: as title
pms: BUG-289409